Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Building of Docker image in CircleCI build process #909

Open
munen opened this issue Dec 2, 2022 · 7 comments
Open

fix: Building of Docker image in CircleCI build process #909

munen opened this issue Dec 2, 2022 · 7 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@munen
Copy link
Collaborator

munen commented Dec 2, 2022

This used to work fine, but then time came and eroded some dependency.

Here's a commit showing functioning builds for all tests, but failing to build the Docker image: 9e3de1a

Relevant code to enable the build, again: a7c8386

@munen munen added the good first issue Good for newcomers label Dec 2, 2022
@mohitsaxenaknoldus
Copy link

Hey, I'd like to work on this. Can you please assign it to me?

@munen munen assigned munen and mohitsaxenaknoldus and unassigned munen Dec 3, 2022
@munen
Copy link
Collaborator Author

munen commented Dec 3, 2022

@mohitsaxenaknoldus Thank you for stepping up 🙏

Happily assigning to you!

@mohitsaxenaknoldus
Copy link

@munen I fixed one of the errors but now it is failing on:

Step 9/14 : RUN yarn global add serve && yarn build && yarn cache clean && rm -rf node_modules ---> Running in 43d52dd325bd yarn global v1.19.1 [1/4] Resolving packages... [2/4] Fetching packages... error is-port-reachable@4.0.0: The engine "node" is incompatible with this module. Expected version "^12.20.0 || ^14.13.1 || >=16.0.0". Got "12.13.1" error Found incompatible module. info Visit https://yarnpkg.com/en/docs/cli/global for documentation about this command. The command '/bin/sh -c yarn global add serve && yarn build && yarn cache clean && rm -rf node_modules' returned a non-zero code: 1

I know Docker and CircleCI but do not know much about node. Can you help with this if possible?

@munen
Copy link
Collaborator Author

munen commented Dec 3, 2022

hihi, that's literally the problem this issue is talking about. This is the error for which this issue was created:

image

@mohitsaxenaknoldus
Copy link

The issue is due to node version incompatibility. We can update the node version but somewhere in the docs, I read that we only need version 12.13.1. Exactly due to which commit did this break? Can we upgrade the node version?

@munen
Copy link
Collaborator Author

munen commented Dec 4, 2022

No commit is responsible, we didn't make any recent changes to Node. It's just drift in the CI.

@mohitsaxenaknoldus
Copy link

Something to start with: #915
@munen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants