Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUDA_ERROR_ILLEGAL_ADDRESS, CPU support, TensorFlow bindings, some other changes #1

Open
albertz opened this issue Sep 16, 2022 · 2 comments

Comments

@albertz
Copy link

albertz commented Sep 16, 2022

Hey!

Thank you for this implementation!

I just wanted to say that we use your implementation and have done some changes, extensions and fixes to it. Unfortunately I don't really have time currently to prepare PRs for the individual changes, at least right now, and we anyway probably stay within our fork (but then I also don't expect that we will really do much further changes now). However, I still wanted to mention that we have done these changes, which are partly probably also interesting to you.

Our fork: https://github.com/rwth-i6/warp-rna

For example, we got a CUDA_ERROR_ILLEGAL_ADDRESS error, due to illegal memory access, reported here: rwth-i6/returnn#1124. I think this was caused when you have cases where S > T. We fixed that now.

Further, we also implemented CPU support, in a somewhat hacky way, by wrapping up the CUDA code with some clever makros, which make it runnable on CPU without CUDA. See here to get an idea how this works.

And we also added TensorFlow bindings.

@1ytic
Copy link
Owner

1ytic commented Sep 17, 2022

Hey, Albert! I'm curious why you chose this implementation? Because it is a rare implementation of RNA or because of CUDA warps threads? In any case, I'm glad to see you use this project. I built this mostly as a toy example and do not use it anymore.

@albertz
Copy link
Author

albertz commented Sep 17, 2022

Do you know a better RNA implementation? I don't really remember anymore why we took this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants