Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI is missing quotes on placeholder attributes #1873

Open
g-regor opened this issue Jan 18, 2024 · 2 comments
Open

WebUI is missing quotes on placeholder attributes #1873

g-regor opened this issue Jan 18, 2024 · 2 comments

Comments

@g-regor
Copy link

g-regor commented Jan 18, 2024

For example when MQTT_SERVER is set to "", HTML is served as <input id='mh' placeholder= value='mqtt-broker.local'>, which the browser parses as <input id="mh" placeholder="value='mqtt-broker.local'" name="mh"> and is then shown as
image

The same problem also occurs for MQTT_PORT, MQTT_USER and Gateway_Name.
Space in the value is also problematic as it makes it show up only partialy.
i.e. for #define Gateway_Name "OpenMQTTGateway One" it only shows "OpenMQTTGateway" as the placeholder.

Steps to reproduce the behavior:

  1. Build the firmware (v1.7.0) with WebUI enabled and with MQTT_SERVER, MQTT_PORT, MQTT_USER and Gateway_Name set as empty strings.
  2. Configure the gateway
  3. Check the MQTT configuration on the WebUI
Copy link

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale label Apr 18, 2024
Copy link

github-actions bot commented May 2, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as completed May 2, 2024
@1technophile 1technophile reopened this May 2, 2024
@1technophile 1technophile removed the stale label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants