Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set title to empty string #18

Closed
1j01 opened this issue Mar 30, 2024 · 1 comment
Closed

Can't set title to empty string #18

1j01 opened this issue Mar 30, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@1j01
Copy link
Owner

1j01 commented Mar 30, 2024

Just noticed this deficiency:

os-gui/$Window.js

Line 1480 in bb4df0f

if (title) {

It's a jQuery-style method that either sets or gets the title, but empty strings are falsy so this would be a slight pitfall as it would simply return the current title instead of setting it to the empty string.

@1j01 1j01 added the bug Something isn't working label Mar 30, 2024
@1j01
Copy link
Owner Author

1j01 commented May 29, 2024

Fixed in 596488a

@1j01 1j01 closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant