Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fretboard note playing indicators #6

Open
1j01 opened this issue Jan 16, 2018 · 1 comment
Open

Improve fretboard note playing indicators #6

1j01 opened this issue Jan 16, 2018 · 1 comment

Comments

@1j01
Copy link
Owner

1j01 commented Jan 16, 2018

Currently it looks broken, like it's got an offset that's not supposed to be there.
It is actually intentional, it's offset so it overlaps the fret that that would be contacted physically.

It should be something more like a circle (where you'd put your finger), blobbily connected to an oval on the fret, or a highlight of the fret. It might look like a bombshell, which might be weird. Maybe it shouldn't be connected? idk
The highlight that represents a finger should move along with your mouse / finger / etc. (and be centered for playback, or if articulations are implemented, it could slide and stuff too)

@1j01
Copy link
Owner Author

1j01 commented Feb 26, 2018

Improved a bit in aad53a3
improved

It definitely looks weird and complicated and like a bomb if I do this:
bombshells
bombshells 2

@1j01 1j01 changed the title Improve display of notes on fretboard Improve display of note playing indicators on the fretboard Aug 8, 2018
@1j01 1j01 changed the title Improve display of note playing indicators on the fretboard Improve fretboard note playing indicators Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant