Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection clears redo #23

Open
1j01 opened this issue Aug 8, 2018 · 1 comment
Open

Selection clears redo #23

1j01 opened this issue Aug 8, 2018 · 1 comment
Labels

Comments

@1j01
Copy link
Owner

1j01 commented Aug 8, 2018

Also it doesn't restore selections when undoing/redoing, it just selects everything.
redo broken by selection

@1j01 1j01 added the bug label Aug 8, 2018
@1j01
Copy link
Owner Author

1j01 commented Aug 8, 2018

After implementing undo/redo button graying (when there are no undos/redos), it's clear it's actually the unfocusing logic (which parses and stringifies tablature)
redo broken by selection or rather unfocusing by the parsing and stringification logic

guitar/src/app.coffee

Lines 220 to 226 in 21b3b3c

# @TODO: maybe listen for change and indicate that you need to unfocus it to update
# or better yet just conditionally show a button
tablature_editor.editor.on "blur", ->
text = tablature_editor.editor.getValue()
load_tablature(text)
return

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant