Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TERRIBLE variable names in this project #10

Open
1j01 opened this issue Feb 26, 2018 · 1 comment
Open

TERRIBLE variable names in this project #10

1j01 opened this issue Feb 26, 2018 · 1 comment

Comments

@1j01
Copy link
Owner

1j01 commented Feb 26, 2018

Inconsistent styling, and unpleasant to work with because I can't tell what things are just by looking at them
For instance I got tripped up by the difference between str and s, which are both abbreviations of the word "string", but one of which is a GuitarString and one of which is a number (an index into the array of guitar strings). Neither are strings, which is funny, but, ay-ai-ai, not good, not good stuff

@1j01
Copy link
Owner Author

1j01 commented Feb 26, 2018

Also I should move the source files to a folder, and set up auto formatting

and update dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant