Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more funny phrases! #6

Open
1egoman opened this issue Oct 16, 2016 · 13 comments
Open

Add more funny phrases! #6

1egoman opened this issue Oct 16, 2016 · 13 comments
Labels
good first issue hacktoberfest help wanted low-hanging-fruit

Comments

@1egoman
Copy link
Owner

1egoman commented Oct 16, 2016 •
edited

We can always use more funny phrases!

Add them to the array in here, as strings. Make sure you add a trailing comma to the end of the array to attempt to make each merge as clean as possible, though it's unlikely that the merge will be 100% clean with this issue.

This is a great first pull-request for those unfamiliar with Github. Feel free to ask for assistance if you need some help!
@chitchu
Copy link

chitchu commented Oct 16, 2016

Is there a character limit?

@1egoman
Copy link
Owner Author

1egoman commented Oct 16, 2016

@chitchu Around 80 chars (more importantly, they should be able to fit on one line)

@chardane chardane mentioned this issue Oct 17, 2016
Merged
@chitchu
Copy link

chitchu commented Oct 17, 2016

Gotcha. FYI line 37 is 91 characters long.

@1egoman
Copy link
Owner Author

1egoman commented Oct 17, 2016 •
edited

Thanks #4 #5 #7 #8 #12 #15 #18 #22 #32 #33 #34 #35 #39 for the 😆 s!

@mishakuzma mishakuzma mentioned this issue Oct 17, 2016
Closed
@bdharris08 bdharris08 mentioned this issue Oct 17, 2016
Merged
@Melon-Bread Melon-Bread mentioned this issue Oct 17, 2016
Closed
This was referenced Oct 17, 2016
Merged
Merged
@renanvalentin renanvalentin mentioned this issue Oct 17, 2016
Open
@collinx
Copy link
Contributor

collinx commented Oct 17, 2016

i would like to add some phrases. Can i?

@1egoman
Copy link
Owner Author

1egoman commented Oct 17, 2016

@collinx Go for it!

mithun-daa added a commit to mithun-daa/funnies that referenced this issue Oct 17, 2016
@mithun-daa
1egoman#6: Add more funnies
c043363
1egoman pushed a commit that referenced this issue Oct 17, 2016
@mithun-daa @1egoman
#6: Add more funnies (#35)
1e6a21e
@xingwang xingwang mentioned this issue Oct 18, 2016
Merged
@tadityar tadityar mentioned this issue Oct 19, 2016
Merged
@purnimamehta purnimamehta mentioned this issue Oct 19, 2016
Merged
@FleetAdmiral
Copy link
Contributor

@1egoman Hey, i'd like to add more phrases. Is there any domain on the jokes that can be made or can we add anything humorous?

@1egoman
Copy link
Owner Author

1egoman commented Oct 22, 2016 •
edited

@FleetAdmiral A few requirements:

  • Keep them to one line. Excessively long jokes are hard to predictably format across different platforms.
  • Jokes shouldn't be offensive, racist, sexist, etc. If you question whether a joke may fall into this category just don't add it.
  • Though there already are a bunch, try to stay away from political jokes. I'm really just looking for jokes that are more "universally" funny and some may fine them offensive, etc...

Other than that, not really. I'll be more likely to accept a PR if I think it's funny though 😄 !

@FleetAdmiral
Copy link
Contributor

@1egoman Awesome! BTW, great project you've got going on over here, pity i hadn't heard of it (i have a thing for fun projects). Keep working on it (will love to contribute more tbh) !

@1egoman
Copy link
Owner Author

1egoman commented Oct 22, 2016

@FleetAdmiral Thanks! Always looking for more funny jokes!

@FleetAdmiral FleetAdmiral mentioned this issue Oct 22, 2016
Merged
@itaisteinherz itaisteinherz mentioned this issue Oct 26, 2016
Merged
1egoman pushed a commit that referenced this issue Oct 28, 2016
@bronwynbiro @1egoman
Contributing to issue #6, added more funnies (#19)
02c672a 
* Contributing to issue #6, added more funnies 

Let me know if you don't line some of them or want any changes!

* fixed typo
This was referenced Oct 28, 2016
Closed
Merged
@hafgan hafgan mentioned this issue Oct 29, 2016
Merged
1egoman pushed a commit that referenced this issue Oct 29, 2016
@hafgan @1egoman
Adding funny phrases (#65)
fc80fa3 
* Update funnies.js

Add more funny phrases!  #6

* Update funnies.js
@kme211 kme211 mentioned this issue Oct 31, 2016
Merged
@abhishekvp abhishekvp mentioned this issue Sep 28, 2017
Merged
@znafziger znafziger mentioned this issue Oct 1, 2017
Merged
@jeremytbrun
Copy link
Contributor

@1egoman can you add a label to this Issue indicating that it is good for beginner level? Suggestion something like "low-hanging-fruit". Would like to include it in a listing of repositories for good beginner PR's.

@1egoman
Copy link
Owner Author

1egoman commented Oct 2, 2017

@jeremytbrun Good idea!

@drevantonder drevantonder mentioned this issue Oct 2, 2017
Closed
@lhphan lhphan mentioned this issue Oct 3, 2017
Merged
@CrowsVeldt
Copy link
Contributor

I'll try to think of something that hasn't been added already :)

1egoman pushed a commit that referenced this issue Oct 29, 2017
@CrowsVeldt @1egoman
#6 - Add funny phrases (#100)
de2bed6 
* Add some "jokes"

* Made joke funnier!

* Reverse accidental change of double- to singel-quotes
@alisonjo315 alisonjo315 mentioned this issue Oct 31, 2017
Merged
1egoman pushed a commit that referenced this issue Oct 2, 2019
@bernhardriegler @1egoman
#6 add new funny phrase (#110)
56890c3
cdmackeyfree pushed a commit to cdmackeyfree/funnies that referenced this issue Oct 15, 2019
Office Space funny
068a0f6 
1egoman#6
@cdmackeyfree cdmackeyfree mentioned this issue Oct 15, 2019
Merged
1egoman pushed a commit that referenced this issue Oct 15, 2019
@1egoman
Office Space funny (#114)
4183977 
#6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue hacktoberfest help wanted low-hanging-fruit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@chitchu @1egoman @CrowsVeldt @collinx @FleetAdmiral @jeremytbrun