Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

border #154

Open
Kazturin opened this issue Sep 19, 2023 · 8 comments
Open

border #154

Kazturin opened this issue Sep 19, 2023 · 8 comments

Comments

@Kazturin
Copy link

Hello.
Each element has a border as a result.

@Josh961
Copy link

Josh961 commented Feb 1, 2024

Had to pull down the code and fix this one for what I'm doing. After a little bit of playing around, the problem method was copyOptions() under toSvg() on line 91 in dom-to-image-more.js.

I just ended up copy pasting dom-to-image-more.js into my project, deleted that line and method, and the border issue was solved. This was enough for my use case. I didn't need to use copyDefaultStyles, imagePlaceholder, cacheBust, etc.

@IDisposable
Copy link
Member

What was the specific change you needed, would be happy to integrate.

@Josh961
Copy link

Josh961 commented Feb 2, 2024

Just to give some context to what the issue looked like, for whatever reason, I was getting gray borders around each div in my generated images (ignore watermarks):

image

Deleting copyOptions() gave me correct images:

image

I'm not sure why this fixes things. I did not dive that deep into it. Only deduced what method was causing the issue and deleted it without problems.

In reference to the specific change, I guess you could integrate an optional parameter to skip applying options?

@rr210
Copy link

rr210 commented Apr 23, 2024

Just to give some context to what the issue looked like, for whatever reason, I was getting gray borders around each div in my generated images (ignore watermarks):只是为了提供一些背景信息来说明问题的情况,无论出于何种原因,我在生成的图像中的每个 div 周围都出现了灰色边框(忽略水印):

image

Deleting copyOptions() gave me correct images:删除 copyOptions() 给了我正确的图像:

image

I'm not sure why this fixes things. I did not dive that deep into it. Only deduced what method was causing the issue and deleted it without problems.我不知道为什么这可以解决问题。我并没有深入研究它。仅推断出导致问题的方法并将其删除,没有出现任何问题。

In reference to the specific change, I guess you could integrate an optional parameter to skip applying options?关于具体的更改,我想您可以集成一个可选参数来跳过应用选项?

I deleted it but the problem is not solved, there is still a border.
image

@risalfajar
Copy link

risalfajar commented Apr 25, 2024

Is there no solution yet? This issue preventing us to use this library

@IDisposable
Copy link
Member

I still need a minimal repro as a JSFiddle, please

@PhamMinhKha
Copy link

same

@srsholmes
Copy link

Use html-to-image as an alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants