Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vestigial SAML references #194

Open
brodygov opened this issue Mar 6, 2019 · 0 comments
Open

Remove vestigial SAML references #194

brodygov opened this issue Mar 6, 2019 · 0 comments

Comments

@brodygov
Copy link
Contributor

brodygov commented Mar 6, 2019 •
edited

The dashboard switched from SAML to OIDC a year ago, but still has a lot of references to SAML in disabled tests and in dependencies.

bac2d0e

We should ideally replace these tests with relevant tests for OIDC and remove all the unused references to SAML.

There are a number of config variables that refer to SAML when they are actually used for OIDC.

  • saml_sp_private_key is actually used for OIDC
  • saml_sp_certificate is not used, since OIDC doesn't use certificates, but it's required by config/initializers/figaro.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brodygov