IE section of browsers chart is rendering improperly

[tdlowden]

What kind of issue?

• Feature Request?
• [x ] Bug

In the https://analytics.usa.gov/executive-office-president/ and https://analytics.usa.gov/national-aeronautics-space-administration/, the Internet Explorer part of the Browsers chart is rendering as its own separate chart, with "Internet Explorer" in bold, and not representing a total percentage rather than just the % of IE versions. It should be a nested chart within the "Browsers" section.

[tdlowden]

Thanks to @ryanhofdotgov, we have this info:

Since IE doesn’t exist in the Browser section, this logic doesn’t work. Normally it would render as a sub-chart.

Who would have thought we would live in a world where IE usage falls off the chart?

The offending line of code is really this one:

analytics.usa.gov/js/index.js

Line 89 in 92fe548

whenRendered(['browsers', 'ie'], () => {

Needs to check if the Internet Explorer Key exists in the parent chart before nesting it. Technically also needs to be done with all the other nested charts.

[ryanwoldatwork]

It appears the the Internet Explorer details are rendered all the time.
After render, the code loops through the browsers listed under "Browsers" and will nest the Internet Explorer element.

However, here, "Internet Explorer" is not showing in the "Browsers" element, so the Internet Explorer element doesn't get nested, as intended.

[ryanwoldatwork]

Here's a PR #767

The javascript line is perhaps overly cautious, and certainly ugly. But the general take here is to render AND hide the Internet Explorer section by default. And if the Browser section shows an "Internet Explorer" entry, the hidden section will show and be nested. If an entry for IE does not show, the original section will remain hidden.