Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite reading of strings from HDF5 to comply with h5py 3.x #40

Open
1313e opened this issue Nov 4, 2020 · 0 comments
Open

Rewrite reading of strings from HDF5 to comply with h5py 3.x #40

1313e opened this issue Nov 4, 2020 · 0 comments

Comments

@1313e
Copy link
Owner

1313e commented Nov 4, 2020

h5py 3.0 changed the way in which strings are read from HDF5.
It now returns them as unicode strings instead of bytes strings.
Although I am happy that this has finally been changed, code everywhere assumes that the strings are read in as bytes, and therefore convert them to unicode.

The PRISM code can be easily changed to reflect this, but it would also force users to always use h5py 3.x, which I think is a bit too early to do.
Therefore, for now, PRISM will not support the use of h5py 3.x until the latter has released a few versions.

1313e added a commit that referenced this issue Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant