Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: apply concurrency to individual sharp instances #210

Merged
merged 1 commit into from Apr 19, 2024
Merged

feat: apply concurrency to individual sharp instances #210

merged 1 commit into from Apr 19, 2024

Conversation

ryanccn
Copy link
Contributor

@ryanccn ryanccn commented Feb 10, 2024 •
edited

Closes #205

@zachleat zachleat added this to the Eleventy Image v5.0.0 milestone Apr 19, 2024
@zachleat zachleat merged commit b46f0a4 into 11ty:main Apr 19, 2024
@zachleat
Copy link
Member

Shipping with 5.0.0-alpha.1, thank you!!

@zachleat zachleat added the enhancement New feature or request label Apr 19, 2024
@zachleat zachleat removed this from the Eleventy Image v5.0.0 milestone Apr 21, 2024
@zachleat
Copy link
Member

zachleat commented Apr 21, 2024 •
edited

Unfortunately I had to revert this one, it was causing this test to consistently break in Windows. We'll have to try again another day!

test › Keep a cache, don’t reuse with if the image changes, check output

  Rejected promise returned by test. Reason:

  Error {
    code: 'UNKNOWN',
    dest: 'C:\\Users\\eleve\\code\\eleventy-img\\test\\generated-modify2-bio.jpg',
    errno: -4094,
    path: 'C:\\Users\\eleve\\code\\eleventy-img\\test\\modify2-bio-grayscale.jpg',
    syscall: 'copyfile',
    message: 'UNKNOWN: unknown error, copyfile \'C:\\Users\\eleve\\code\\eleventy-img\\test\\modify2-bio-grayscale.jpg\' -> \'C:\\Users\\eleve\\code\\eleventy-img\\test\\generated-modify2-bio.jpg\'',
  }

  Error: UNKNOWN: unknown error, copyfile 'C:\Users\eleve\code\eleventy-img\test\modify2-bio-grayscale.jpg' -> 'C:\Users\eleve\code\eleventy-img\test\generated-modify2-bio.jpg'
      at Object.copyFileSync (node:fs:3005:11)
      at C:\Users\eleve\code\eleventy-img\test\test.js:551:6

https://github.com/11ty/eleventy-img/actions/runs/8759975926

zachleat added a commit that referenced this pull request Apr 21, 2024
@zachleat
Revert #210 to fix Windows tests.
f894cfd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image.concurrency option is confusing
2 participants
@ryanccn @zachleat