Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be clear that permalink and excludeFromCollections are at the mercy of downstream logic #173

Open
AramZS opened this issue Mar 18, 2024 · 0 comments

Comments

@AramZS
Copy link

AramZS commented Mar 18, 2024

I'm trying to figure my way through the eleventy.config.drafts.js plugin and as far as I can tell you're basically replacing the logic downstream of the plugin on the permalink and eleventyExcludeFromCollections properties of every post? I think I have that correct?

The issue is that if that's the approach and any other data file or function touches either of those the logic gets overwritten right? Then it ends up with the draft logic in the plugin never running? That's a pretty easy thing to mess up on, the documentation often prods users to--at the very least--manipulate permalink on eleventyComputed.

Have I got this issue correct? Is this indeed what can happen? If so, I don't think that's very clear in the code and it could likely use some inline comments. I'd be glad to submit a PR if so, but I'm not quite sure I've got the problem I'm seeing locked down and want to double check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant