-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authorization Failing // Truncate Referrer URLs #418
Comments
@superbuggy welcome to Distributor and thanks for the feedback! I'm tagging this for review during our upcoming 1.5.0 release, so stay tuned for an update then. @dkotter any chance your improvements to the Pull Content page resolve this issue? |
Thanks @superbuggy - I think it definitely makes sense to truncate the referer/referrer URL for now, am looking into whether it's better to cut all the way back to site URL or use the current admin page URL. I also would love your opinion on whether long-term it would be better to stop shoving excluded posts into the the query string (leaving the actual functionality intact) and refer to a stored option instead. |
After digging into this some more with @dkotter's help, I can trigger this easily by setting
Any thoughts/objections? Working on a PR now. |
@superbuggy I've opened #431 to address this, if you're able to take a look and give an opinion on the approach and/or the UI results and how that impacts you. |
Coming back with more due diligence before I merge #431 in - with @cmmarslender on the assist, it looks to be a |
Sounds good! In our case, I just added in the code block above to Story the post exclusion list on the remote makes sense to me as well. Feels an intuitive that a site should keep track of which posts it has already pulled in. This could be stored in the options table, maybe? |
Thank you for your responses! |
Describe the bug
Distributor generates some large URLs that include potentially long lists of posts in the URL's query string. WP includes the entire URL as
Referrer
in the header for outbound requests. With long enough URLs (~8k+ UTF-8 chars), this will invalidate headers with servers that are configured with an 8kb size limit for headers, as it did in our case (wamu.org
). The headers get garbled, and since they authorization data, this ultimately causes authorization to fail.Steps to Reproduce
Pull Content from
dropdown.Could not pull content from connection due to error.
Expected behavior
Headers should not have the full URL so they don't get garbled.
Screenshots
Environment information
Additional context
Proposed Solution: Truncate the referrer URL...
The text was updated successfully, but these errors were encountered: