Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Notice while updating a term is not displaying when plugin is network activated #3604

Open
1 task done
MARQAS opened this issue Aug 15, 2023 · 1 comment
Open
1 task done
Labels
bug Something isn't working
Milestone

Comments

@MARQAS
Copy link
Contributor

MARQAS commented Aug 15, 2023

Describe the bug

The warning on the term page is not showing If the items per cycle are less than the posts attached to a term, it should display the warning even if the plugin is network activated.

Steps to Reproduce

  1. Enable the plugin from the Network side
  2. Reduce the Content Items per Index Cycle to less than the posts attached to a term
  3. Edit a term in a single site and notice that the warning is not showing up

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress and ElasticPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@MARQAS MARQAS added the bug Something isn't working label Aug 15, 2023
@felipeelia felipeelia added this to the 5.0.0 milestone Aug 17, 2023
@felipeelia felipeelia modified the milestones: 5.0.0, 4.7.2 Sep 22, 2023
@felipeelia
Copy link
Member

Adding this back to the 5.0.0 milestone, as it is more complex than it seems. Actually, it seems if the plugin is network-activated, ALL our notices are only displayed in the network admin context. To allow specific warnings in subsites admins we would have to come up with a mechanism to target contexts per notice.

@felipeelia felipeelia modified the milestones: 5.0.0, 5.1.0 Nov 1, 2023
@felipeelia felipeelia modified the milestones: 5.1.0, 5.2.0 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants