Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom block type per blacklist group #1419

Open
bozicm opened this issue Mar 29, 2024 · 3 comments
Open

Custom block type per blacklist group #1419

bozicm opened this issue Mar 29, 2024 · 3 comments
Labels
🔨 enhancement New feature or request
Milestone

Comments

@bozicm
Copy link

bozicm commented Mar 29, 2024

I don't care much about adware and in that case zeroIP or nxDomain response is good enough. But for malware&co I do want to have a custom IP redirect where a warning message for the mentioned page is displayed.

Would it be possible to refactor the blockType to support different response options per blacklist group? For example, the config would be like:

blocking:
  blackLists:
    ads:
      - https://s3.amazonaws.com/lists.disconnect.me/simple_ad.txt
    malware:
      - verybadsite.xyz
blocking:
  blockType: nxDomain
  groupTypes:
     - ip: 123.123.123.123
       lists:
         - malware
@kwitsch kwitsch added the 🔨 enhancement New feature or request label Mar 31, 2024
@kwitsch
Copy link
Collaborator

kwitsch commented Mar 31, 2024

Sounds reasonable even if you're idea would most likely end up in an SSL warning page since almost all requests are done with HTTPS and even if your warning page has a correct certificate it wouldn't match with the requested URL.

@kwitsch kwitsch added this to the future milestone Mar 31, 2024
@bozicm
Copy link
Author

bozicm commented Apr 3, 2024

Sounds reasonable even if you're idea would most likely end up in an SSL warning page since almost all requests are done with HTTPS and even if your warning page has a correct certificate it wouldn't match with the requested URL.

Yes, I'm aware that incorrect certificate might be an issue but IMO this is better than generic error. On the other hand, it really depends on the implementation of the URL redirection on the http://123.123.123.123 ?

@kwitsch
Copy link
Collaborator

kwitsch commented Apr 3, 2024

Depends on your use case since most users get suspicious at SSL errors.
Seeing nothing is in most cases less alarming than seeing the "Not secure" warning in your browser as a user.

It might be possible to set up SSL man-in-the-middle to combat those but this is really painful and most likely isn't beneficial for your user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants