Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve how we pass config into ParallelBestResolver #1258

Open
ThinkChaos opened this issue Nov 18, 2023 · 0 comments
Open

Improve how we pass config into ParallelBestResolver #1258

ThinkChaos opened this issue Nov 18, 2023 · 0 comments
Labels
🧰 technical debts Technical debts, refactoring
Milestone
future

Comments

@ThinkChaos
Copy link
Collaborator

MoveshouldVerifyUpstreams bool into UpstreamsConfig so we can pass that everywhere we currently pass shouldVerifyUpstreams. This will allow passing more generic config and avoid some config.Config() usage.

See #1221 (comment)

I've got a WIP (old) branch locally for this, I'll clean it up and either finish if it's quick or pass it on to @DerRockWolf
@ThinkChaos ThinkChaos mentioned this issue Nov 18, 2023
Merged
@kwitsch kwitsch added the 🧰 technical debts Technical debts, refactoring label Nov 19, 2023
@kwitsch kwitsch added this to the future milestone Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🧰 technical debts Technical debts, refactoring
Projects
None yet
Milestone
future
Development

No branches or pull requests
2 participants
@ThinkChaos @kwitsch