Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect waterfall indices in dedispersion operation #9

Open
0xCoto opened this issue Mar 24, 2021 · 0 comments
Open

Incorrect waterfall indices in dedispersion operation #9

0xCoto opened this issue Mar 24, 2021 · 0 comments

Comments

@0xCoto
Copy link
Owner

0xCoto commented Mar 24, 2021

There appears to be somewhat of an inaccurate application of the incoherent dedispersion formula, yielding this error:

Traceback (most recent call last):
  File "quick_obs.py", line 34, in <module>
    obs_file='observation.dat', plot_file='plot.png')
  File "/home/apostolos/.local/lib/python3.5/site-packages/virgo/virgo.py", line 565, in plot
    shift(t_bin, n)
  File "/home/apostolos/.local/lib/python3.5/site-packages/virgo/virgo.py", line 450, in shift
    waterfall[:, phase_num] = np.roll(waterfall[:, phase_num], -n_rows)
IndexError: index 256 is out of bounds for axis 1 with size 256

I've only noticed this error just now with a long observation. I suspect there is a mistakenly flipped order (i.e. mixing waterfall indices, ultimately trying to shift channels instead of time bins).

Lines 449-450 and 557-565 are suspicious, but I couldn't figure out a solution from a quick look. Furhter investigation is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant