Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GR 3.8/3.9 compatibility #7

Open
0xCoto opened this issue Mar 5, 2021 · 5 comments
Open

GR 3.8/3.9 compatibility #7

0xCoto opened this issue Mar 5, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@0xCoto
Copy link
Owner

0xCoto commented Mar 5, 2021

I just discovered what has been causing issues for GR 3.8/3.9. Seems like the dev_args and obs_file parameter blocks are set to Type: None, but setting them to String resolves problems.

To-do: Test if Type: String is compatible with GR 3.7 as well, or if only Type: None is the exclusive workaround for the old version, and integrate the fix.

@0xCoto 0xCoto added the enhancement New feature or request label Mar 5, 2021
@awasisto
Copy link

awasisto commented Mar 9, 2021

What issue? It's working fine on GnuRadio 3.8.2.0 with dev_args and obs_file types set to None

@0xCoto
Copy link
Owner Author

0xCoto commented Mar 9, 2021

Really? That's interesting. I guess the issue only applies to version 3.9 then. Thanks for informing!

@awasisto
Copy link

Just tested on GnuRadio 3.9.0.0. You're right, it fails to run. Changing dev_args and obs_files types to String works and it still works on 3.8.2.0. So I believe they're safe to change

@awasisto
Copy link

Update: I've just tested the modified grc on 3.7.13.4 and it doesn't work. I guess the fix is not backward compatible with 3.7

@0xCoto
Copy link
Owner Author

0xCoto commented Mar 20, 2021

Thanks a lot, that's a valuable observation! Since many users appear to still be using GR 3.7 (but an equally large amount has shifted to 3.8/3.9), my plan is to include two new .grc flowcharts in the same directory (one for FTF & one for WOLA), and assign two of them for 3.7 and the other two for 3.8/3.9. Once I find some time to push the fix, Virgo should be GR-3.7/3.8/3.9 compatible. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants