Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add theming functionality #328

Open
Lamparter opened this issue Oct 18, 2022 · 1 comment
Open

Feature: Add theming functionality #328

Lamparter opened this issue Oct 18, 2022 · 1 comment
Assignees
Labels
feature request This issue is a feature request.

Comments

@Lamparter
Copy link
Collaborator

Lamparter commented Oct 18, 2022

Description and Motivation

Adds theming to FluentHub. This can be achieved by creating multiple files with different Primer resources that the user can select.

Motivation & Context

Related: #158
Related: #163

### Tasks
- [ ] Improve border and some of SolidColorBrushes which contains in FluentHubDefault.xaml theme resources to use system default theme resources.
- [ ] Add theme switching helper class methods
- [ ] Add various GitHub's official themes
- [ ] Display those themes in app appearance settings page
@Lamparter Lamparter mentioned this issue Oct 18, 2022
1 task
@Lamparter Lamparter added this to the Post v1 milestone Oct 18, 2022
@Lamparter Lamparter linked a pull request Oct 18, 2022 that will close this issue
2 tasks
@0x5bfa
Copy link
Owner

0x5bfa commented Oct 18, 2022

I copied and converted(argb -> hex) from here https://primer.style/primitives/colors

And to achieve this goal, I think we have to create theme switcher, of course.

@0x5bfa 0x5bfa self-assigned this Oct 18, 2022
@0x5bfa 0x5bfa added the feature request This issue is a feature request. label Oct 18, 2022
@0x5bfa 0x5bfa changed the title Add theming Feature: Add theming functionality Feb 10, 2023
@0x5bfa 0x5bfa removed the tracker label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request This issue is a feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants