Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add page content caching service #248

Open
1 task done
Lamparter opened this issue Sep 1, 2022 · 3 comments
Open
1 task done

Feature: Add page content caching service #248

Lamparter opened this issue Sep 1, 2022 · 3 comments
Assignees
@0x5bfa
Labels
feature request This issue is a feature request.
Milestone
FluentHub v1.0.0

Comments

@Lamparter
Copy link
Collaborator

⏱️ Before you start...

  • Have you checked if a similar feature request has already been reported?

📄 Description

Implement cache so if the user has no internet, FluentHub doesn't break immediately.

🗃️ Alternative solutions

None.

📸 Assets

None
@Lamparter Lamparter added the feature request This issue is a feature request. label Sep 1, 2022
@0x5bfa 0x5bfa added more info This issue/PR needs more infomation. help wanted This issue/PR needs help. priority-high triage approved This issue has been approved by an FH member. labels Sep 1, 2022
@0x5bfa 0x5bfa added this to the FluentHub v0.5 milestone Sep 1, 2022
@0x5bfa
Copy link
Owner

0x5bfa commented Sep 1, 2022

I'm not sure we should use cache. Cache is for not getting extra data. But shouldn't do like that due to it's characteristics of Octokit.GrapgQL.NET

@0x5bfa 0x5bfa changed the title Implement cache Implement caching service Sep 16, 2022
@0x5bfa 0x5bfa self-assigned this Sep 16, 2022
@0x5bfa 0x5bfa removed more info This issue/PR needs more infomation. help wanted This issue/PR needs help. priority-high triage approved This issue has been approved by an FH member. labels Sep 16, 2022
@0x5bfa 0x5bfa mentioned this issue Sep 16, 2022
Closed
1 task
@arihant2math
Copy link
Contributor

Also switching between pages that include api calls takes a bit.

@0x5bfa
Copy link
Owner

0x5bfa commented Sep 16, 2022

Yes. I'm thinking of displaying the control first and displaying it as soon as an error occurs.

@0x5bfa 0x5bfa changed the title Implement caching service Feature: Implement caching service Feb 10, 2023
@0x5bfa 0x5bfa changed the title Feature: Implement caching service Feature: Add page content caching service Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x5bfa 0x5bfa

Labels
feature request This issue is a feature request.
Projects
None yet
Milestone
FluentHub v1.0.0
Development

No branches or pull requests
3 participants
@arihant2math @0x5bfa @Lamparter