Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language server suggestions are too aggressive with dots #268

Open
3 tasks done
zkulbeda opened this issue Mar 16, 2024 · 2 comments
Open
3 tasks done

Language server suggestions are too aggressive with dots #268

zkulbeda opened this issue Mar 16, 2024 · 2 comments

Comments

@zkulbeda
Copy link

zkulbeda commented Mar 16, 2024

Describe the bug

I want to use a fragment and I need to write down 3 dots before fragment name. But in vscode this is happening:

tada

So I have to press esc button after every dot to close the suggection dropdown. I'm using vscode with default settings.

PS: Thank you for such an awesome library!

Reproduction

No response

gql.tada version

1.3.5

Validations

  • I can confirm that this is a bug report, and not a feature request, RFC, question, or discussion, for which GitHub Discussions should be used
  • Read the docs.
  • Follow our Code of Conduct
@JoviDeCroock
Copy link
Member

That's not really the Language server being too aggressive, it's a setting in VSCode 😅 I guess an alternative suggestion here would be to always display the fragment-spread option but when there's a lot of field that might not be a good option either

@JoviDeCroock JoviDeCroock transferred this issue from 0no-co/gql.tada Mar 17, 2024
@Maximaximum
Copy link

The thing is that this issue doesn't happen when using the spread operator in plain JavaScript or Typescript (without regards to the aforementioned VS Code setting). In the latter case, the suggestions ONLY show up after the third dot is typed, whereas with GraphQLSP the suggestions start showing up right after the first dot is typed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants