Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add gas amount estimation feature to zcnbridge #1443

Merged
merged 5 commits into from Mar 28, 2024

Conversation

YarikRevich
Copy link
Collaborator

No description provided.

@YarikRevich YarikRevich self-assigned this Mar 27, 2024
@YarikRevich YarikRevich added the enhancement New feature or request label Mar 27, 2024
@YarikRevich YarikRevich linked an issue Mar 27, 2024 that may be closed by this pull request
go.mod Outdated
go 1.21

toolchain go1.21.5
go 1.18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the reason to downgrade the version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the latest PR I downgraded it to 1.20, cause in all the workflows we use 1.20.3 version, so there were failing

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov changed the base branch from sprint-1.14 to staging March 28, 2024 13:47
@dabasov dabasov changed the base branch from staging to sprint-1.14 March 28, 2024 13:48
@dabasov dabasov merged commit f3ecab4 into sprint-1.14 Mar 28, 2024
8 of 10 checks passed
@dabasov dabasov deleted the feature/gas-estimation branch March 28, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: add gas amount estimation feature to zcnbridge
2 participants