Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocation ownership transfer is not synced from 0chain #728

Open
peterlimg opened this issue Jun 15, 2022 · 8 comments
Open

Allocation ownership transfer is not synced from 0chain #728

peterlimg opened this issue Jun 15, 2022 · 8 comments
Assignees
Labels
bug Something isn't working post-mainnet

Comments

@peterlimg
Copy link
Member

peterlimg commented Jun 15, 2022

Related issue 0chain/gosdk#765

@peterlimg peterlimg added the bug Something isn't working label Jun 15, 2022
@cnlangzi
Copy link
Contributor

@peterlimg all allocation changes should be synced from blockchain. eg size, write_price, read_price...etc

@lpoli
Copy link
Contributor

lpoli commented Jun 24, 2022

@peterlimg @cnlangzi
What should be done to this issue?

@cnlangzi cnlangzi self-assigned this Jul 1, 2022
@dabasov dabasov assigned boddumanohar and unassigned cnlangzi Nov 12, 2022
@boddumanohar
Copy link
Contributor

@peterlimg @cnlangzi can you please give a brief overview on what should done as a part of this ticket?

@peterlimg
Copy link
Member Author

@boddumanohar first, we need to confirm if this bug still exist. So after transferring an allocation's ownership, check if the new owner has the CURD rights? and if how about the old owner.

Second, if the bug still exists, then we will need to check what we can do to fix the issue, most likely as @cnlangzi said above, it is because the ownership data hasn't been sync from 0chain, so perhaps, what we can do are:

  • Update the zboxcli to send message to blobbers to trigger allocation info synching after the ownership transfer txn is confirmed.
  • Implement the sync processor on blobbers.

Another way is to do whole allocations synching periodically, but that may use a lot of resources and cause performance issue as each blobber could have a lot of allocations need to update.

@stewartie4
Copy link
Contributor

@peterlimg just checking if this is still a valid issue, we still see flaky behaviour/periodic test failures

@boddumanohar
Copy link
Contributor

boddumanohar commented Dec 17, 2022

@stewartie4 yes, I've validated and the issue still exists. At the moment, @lpoli is working on it. As is somewhat related to his Writemarker modification PR.

The problem is with respect to write maker signature verification. And the associated discussion can be followed here: https://0chain.slack.com/archives/C01U94VF56Y/p1668931208557289

@dabasov dabasov assigned Hitenjain14 and unassigned lpoli Mar 10, 2023
@Hitenjain14
Copy link
Member

@peterlimg this function https://github.com/0chain/blobber/blob/staging/code/go/0chain.net/blobbercore/handler/storage_handler.go#L41 , updates the allocation right , if yes can we just call this function when zbox cli send the update request with txnhash of update owner transaction .

@dabasov
Copy link
Member

dabasov commented Mar 18, 2023

postponed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working post-mainnet
Projects
None yet
Development

No branches or pull requests

7 participants