-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long search query overflows in message feed when no results found #29568
Comments
Hello @zecbfernandes! Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label. If this is your first time here, we recommend reading our guide for new contributors before getting started. |
I would like to personally fix this issue so if you could assign it to me I would appreciate it! |
…ly Long Word Fixed bug where when searching for an extremely long word that does not resolve to anything, the word/entence would overflow from the screen.Added test aswell
…ly Long Word Fixed bug where when searching for an extremely long word that does not resolve to anything, the word/sentence would overflow from the screen.Added test aswell
Sure, assigning to you, @ilyesskhayati -- thanks! |
Hi @ilyesskhayati, I just noticed your message! I wanted to bring to your attention that I've already made a commit addressing this issue that fixed the bug, but I didn't create the pull request as I wasn't assigned to it. Please take a look at my commits above, where I solved this issue. If you proceed with the pull request, could you please reference my commit? Also, I believe in my second commit, I inadvertently removed the tests I created for my fix so you might have to implement them again. Good luck with the pull request! |
@zecbfernandes For what it's worth, you can create a pull request without being assigned to an issue. The point of assigning issues is to coordinate work better; it should never prevent us from using work that's been done. |
Hello, sorry for the late reply, I was finishing up my Finals exams. I think I will not work on it now, as I still have some things to do, so yeah! |
@alya I did not know that, thanks for clearing that up! I will be submitting a pull request with my fix for the issue soon. |
Expected Behavior:
When searching for an extremely long word, the error message should display "No search results. You searched for: [the long word]" without overflowing the screen. If the complete word does not fit the entire screen, it should be partially hidden.
Actual Behavior:
Upon searching for an extremely long word, the error message overflows the screen, making it difficult to read the complete message.
Steps to reproduce the buggy behaviour:
I forked the software 2 days ago so I can only assume I'm on the latest Zulip version.
The text was updated successfully, but these errors were encountered: