Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename refactor for class/struct/interface members #6484

Open
tsuf239 opened this issue May 15, 2024 · 3 comments · May be fixed by #6637
Open

rename refactor for class/struct/interface members #6484

tsuf239 opened this issue May 15, 2024 · 3 comments · May be fixed by #6637
Assignees
@tsuf239
Labels
✨ enhancement New feature or request 📡 language-server IDE Support needs-discussion Further discussion is needed prior to impl 🔌 vscode-extension Issues related to the Wing VS Code extension

Comments

@tsuf239
Copy link
Collaborator

tsuf239 commented May 15, 2024

Use Case

currently, we can't rename class properties, structs keys, and interface keys since it wasn't supported on #6461

Proposed Solution

No response

Implementation Notes

No response

Component

No response

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.
  • If this issue is labeled needs-discussion, it means the spec has not been finalized yet. Please reach out on the #dev channel in the Wing Slack.
@tsuf239 tsuf239 added ✨ enhancement New feature or request needs-discussion Further discussion is needed prior to impl labels May 15, 2024
@staycoolcall911 staycoolcall911 added the 🔌 vscode-extension Issues related to the Wing VS Code extension label May 21, 2024
@MarkMcCulloh MarkMcCulloh mentioned this issue May 25, 2024
Closed
@MarkMcCulloh MarkMcCulloh changed the title rename refactor for class properties rename refactor for class/struct/interface members May 25, 2024
@eladb
Copy link
Contributor

eladb commented May 25, 2024

Can we at least not give the user a false sense that this is supported until this actually works?

Currently the feature feels broken...

@tsuf239
Copy link
Collaborator Author

tsuf239 commented May 26, 2024

Can we at least not give the user a false sense that this is supported until this actually works?

Currently the feature feels broken...

yes, as soon as we implement this: #6564

@tsuf239
Copy link
Collaborator Author

tsuf239 commented May 28, 2024

currently disabled here: #6573

@tsuf239 tsuf239 self-assigned this May 30, 2024
@tsuf239 tsuf239 linked a pull request Jun 5, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsuf239 tsuf239

Labels
✨ enhancement New feature or request 📡 language-server IDE Support needs-discussion Further discussion is needed prior to impl 🔌 vscode-extension Issues related to the Wing VS Code extension
Projects
Wing
Status: 🤝 Backlog - handoff to owners
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(vscode): rename class and struct members winglang/wing
4 participants
@eladb @MarkMcCulloh @tsuf239 @staycoolcall911