Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When connect to metaMask, got onError triggered before user doing something in wallet. #3943

Closed
1 task done
zslucky opened this issue May 18, 2024 · 6 comments
Closed
1 task done

Comments

@zslucky
Copy link

zslucky commented May 18, 2024

Describe the bug

image

Link to Minimal Reproducible Example

https://codesandbox.io/p/devbox/busy-sinoussi-vg29c7?file=%2Fsrc%2Fcontainers%2FDemo.jsx%3A16%2C1

Steps To Reproduce

  1. Go to reproducible example.
  2. Click the Connect button.
  3. Select desktop -> connect with metamask web extension.

you will see the onError and onSettled triggered before user do something.

Wagmi Version

2.9.2

Viem Version

2.10.9

TypeScript Version

5.36.2

Check existing issues

Anything else?

everything is ok for walletconnect, but not ok for metaMask web extension.

@tmm
Copy link
Member

tmm commented May 19, 2024

Minimal reproduction is not accessible.

Devbox not found
It's likely that the Devbox you're trying to access doesn't exist or you don't have the required permissions to access it.

@tmm tmm added the Needs Reproduction Misc: Needs Reproduction label May 19, 2024
Copy link
Contributor

Hello @zslucky.

Please provide a minimal reproduction using StackBlitz, TypeScript Playground (for type issues), or a separate minimal GitHub repository.

Minimal reproductions are required as they save us a lot of time reproducing your config & environment, and trying to reproduce your issue. See Why reproductions are required.

Please reopen this issue when a reproduction is added.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
@zslucky
Copy link
Author

zslucky commented May 20, 2024

@tmm tmm reopened this May 20, 2024
@tmm tmm removed the Needs Reproduction Misc: Needs Reproduction label May 20, 2024
@tmm
Copy link
Member

tmm commented May 21, 2024

This error is thrown directly by the MM extension when there is already a connect pending (e.g. 'eth_requestAccounts').

@tmm tmm closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
@zslucky
Copy link
Author

zslucky commented May 22, 2024

But seems I did nothing...

Copy link
Contributor

github-actions bot commented Jun 6, 2024

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Wagmi version. If you have any questions or comments you can create a new discussion thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants