Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clamp in C51 #443

Open
XinJingHao opened this issue Jan 7, 2024 · 0 comments
Open

clamp in C51 #443

XinJingHao opened this issue Jan 7, 2024 · 0 comments

Comments

@XinJingHao
Copy link

Hi! The repo C51 really helps a lot!

However, I have a question. In line 226 and 227:
l = b.floor().clamp(0, args.n_atoms - 1)
u = b.ceil().clamp(0, args.n_atoms - 1)

It seems that the clamp() function is redundant? Because t_z is already in v_min and v_max.
Why do we still use it here?

Looking forward to your reply~
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant