Revert mmap_rnd bits back to default value in CI #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 3f725b8, we introduced a change back in march to reduce the entropy of ASLR, because ASAN didn't support it. Now the vm.mmap_rnd_bits was reverted in actions/runner-images#9491 so can remove this changes. Closes valkey-io#519. Signed-off-by: Binbin <binloveplay1314@qq.com>
|
I have tested when actions/runner-images#9491 (comment), it was passed. new sanitizer CI: https://github.com/valkey-io/valkey/actions/runs/9154544134 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #520 +/- ##
=========================================
Coverage 69.83% 69.83%
=========================================
Files 109 109
Lines 61801 61801
=========================================
+ Hits 43158 43159 +1
+ Misses 18643 18642 -1 |
madolson
approved these changes
May 20, 2024
adetunjii
pushed a commit
to adetunjii/valkey
that referenced
this pull request
May 22, 2024
In 3f725b8, we introduced a change back in march to reduce the entropy of ASLR, because ASAN didn't support it. Now the vm.mmap_rnd_bits was reverted in actions/runner-images#9491 so can remove this changes. Closes valkey-io#519. Signed-off-by: Binbin <binloveplay1314@qq.com> Signed-off-by: Samuel Adetunji <adetunjithomas1@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 3f725b8, we introduced a change back in march to reduce the
entropy of ASLR, because ASAN didn't support it. Now the vm.mmap_rnd_bits
was reverted in actions/runner-images#9491 so can remove this changes.
Closes #519.