Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Include ValheimPlus in version string #779

Open
MSchmoecker opened this issue Feb 4, 2023 · 6 comments · May be fixed by #781
Open

[FEATURE REQUEST] Include ValheimPlus in version string #779

MSchmoecker opened this issue Feb 4, 2023 · 6 comments · May be fixed by #781

Comments

@MSchmoecker
Copy link
Contributor

Is your feature request related to a problem? If so, please describe.
ValheimPlus changes the version string to enforce it on all clients, for example 0.212.9 is changed to 0.212.9@0.9.9.11. It is not always clear for new players which mod is doing this and need time to figure this out.

Describe the solution you'd like
The attached string should be changed to include the mod name, so something like 0.212.9-ValheimPlus@0.9.9.11. Since the version string is changed with each V+ version anyway and there is no parsing involved as far as I'm aware, this should be a non-breaking, minor change that helps new players understanding why they can't connect to a server.

@SSimp258
Copy link

SSimp258 commented Feb 4, 2023

So typically, I don't tell a new player or someone new to modding to dig into the log file like you're describing. I normally have them check for the V+ splash on the main menu and then have them check the lower right corner of their game for their version numbers like in the pic. This is the easiest way for a new player or someone new to modding to check their version number. If i suspect something is wrong in the log file, I have that person post the log to the discord so i can read through it since 95% of people don't know how to read the log. It's just easier this way.

image

@MSchmoecker
Copy link
Contributor Author

MSchmoecker commented Feb 4, 2023

Well, the V+ tag doesn't work on a headless server so you can't compare versions there.

If this would be a breaking or big change for V+ I would agree with your point. Log files are more inaccessible then a UI for new players. But since it doesn't change anything in the version check itself but only clarifies it, I don't see why it shouldn't be done.

@OrianaVenture
Copy link

Having a more clear change for the version string would help other communities a lot. Other mod makers don't always know that the version string is being changed by V+, especially new people. The current way is very confusing, even more so for users trying to debug their mod issues with the log files.

@MSchmoecker
Copy link
Contributor Author

To add, the version string can also be shown in vanilla UI since a few Valheim versions when trying to join a server where V+ is not installed. This makes the change even more useful.

image

@kiloforce
Copy link

+1

@SSimp258
Copy link

@kiloforce Please do not comment "+1" on posts. It's not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants