Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate onClick event into onMouseDown and onMouseUp events #5210

Closed
wants to merge 6 commits into from
Closed

Separate onClick event into onMouseDown and onMouseUp events #5210

wants to merge 6 commits into from

Conversation

sweep-ai[bot]
Copy link

@sweep-ai sweep-ai bot commented Sep 18, 2023

Description

This PR separates the onClick event in the tsParticles library into onMouseDown and onMouseUp events. This change improves the options for handling mouse events and allows users to customize the behavior of their particles based on mousedown and mouseup events.

Summary of Changes

  • Modified the Events.ts file to introduce onMouseDown and onMouseUp events and updated the load method to handle data for these events.
  • Updated the EventListeners.ts file to add separate event listeners for mousedown and mouseup events and modified the _doMouseTouchClick method to handle these events separately.
  • Modified the Bubbler.ts and Attractor.ts files to handle mousedown and mouseup events separately in the interact method.
  • Updated the FullScreen.md documentation to reflect the changes made to the onClick event and introduced the new onMouseDown and onMouseUp events.

Please review and merge these changes.

Fixes #4982.

🎉 Latest improvements to Sweep:

💡 To get Sweep to edit this pull request, you can:

  • Leave a comment below to get Sweep to edit the entire PR
  • Leave a comment in the code will only modify the file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-ai sweep-ai bot added the sweep Assigns Sweep to an issue or pull request. label Sep 18, 2023
@sweep-ai sweep-ai bot mentioned this pull request Sep 18, 2023
Open
8 tasks
@sweep-ai
Copy link
Author

sweep-ai bot commented Sep 18, 2023

GitHub actions yielded the following error.

Checking formatting...
[warn] markdown/Options/FullScreen.md
[warn] Code style issues found in the above file. Run Prettier to fix.
ELIFECYCLE  Command failed with exit code 1.

The command that failed is prettier --check ./README.md && prettier --check ./markdown/*.

This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests.

I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR.

@sweep-ai
Copy link
Author

sweep-ai bot commented Sep 18, 2023

GitHub actions yielded the following error.

Checking formatting...
[warn] markdown/Options/FullScreen.md
[warn] Code style issues found in the above file. Run Prettier to fix.
ELIFECYCLE  Command failed with exit code 1.

The command that failed is prettier --check ./markdown/*.

This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests.

I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR.

@sweep-ai sweep-ai bot closed this Oct 1, 2023
@sweep-ai sweep-ai bot deleted the sweep/separate-onclick-events branch October 1, 2023 17:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
size/L sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the onClick event to handle both mouseUp and mouseDown
0 participants