Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Request #2000

Closed
ct-jeffweinberg opened this issue Apr 17, 2024 · 5 comments
Closed

Documentation Request #2000

ct-jeffweinberg opened this issue Apr 17, 2024 · 5 comments
Labels

Comments

@ct-jeffweinberg
Copy link

The template is not relevant to this request.

Please add the excellent documentation from (locationAuthorizationRequest)[https://transistorsoft.github.io/react-native-background-geolocation/interfaces/config.html#3--locationauthorizationrequest-39any39] in the generated API docs to a section in the Home page of the Wiki, or to the Philosophy of Operation section.

While this was my own experience and the best step would have been to thoroughly read the type annotations or the API docs, I found it hard to find relevant information on the idiosyncrasies of iOS location permissions and spent a good amount of time having to read through issues to find what I was looking for. I think that this is an important topic and worthy of its own place in the wiki as the content is already written in a convenient how to guide with code examples.

Thanks for your consideration.

@jrweinb
Copy link

jrweinb commented Apr 17, 2024

Its also worth adding this to the Using the Plugin guide in the Readme:

From the generated docs here:

Warning: You must call #ready once and only once, each time your app is launched.
Do not hide the call to #ready within a view which is loaded only by clicking a UI action. This is particularly important for iOS in the case where the OS relaunches your app in the background when the device is detected to be moving. If you don't ensure that #ready is called in this case, tracking will not resume.

This is easy to miss and not doing it causes subtle bugs that are hard to find as the plugin still mostly works.

@christocracy
Copy link
Member

Thanks for the feedback.

@christocracy
Copy link
Member

Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label May 19, 2024
Copy link

github-actions bot commented Jun 2, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as completed Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants