Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing methods join_set::Builder::spawn_blocking() and join_set::Builder::spawn_blocking_on() #6565

Closed
jbg opened this issue May 15, 2024 · 2 comments · Fixed by #6578
Closed

Missing methods join_set::Builder::spawn_blocking() and join_set::Builder::spawn_blocking_on() #6565

jbg opened this issue May 15, 2024 · 2 comments · Fixed by #6578
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request. E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. M-task Module: tokio/task

Comments

@jbg
Copy link
Contributor

jbg commented May 15, 2024

Is your feature request related to a problem? Please describe.

I want to name a blocking task that is spawned on a JoinSet.

Describe the solution you'd like

The missing methods spawn_blocking() and probably spawn_blocking_on() added to join_set::Builder.

Describe alternatives you've considered

I'm currently spawning the tasks without names, but I prefer everything to be named for ease of debugging with tokio-console.
@jbg jbg added A-tokio Area: The main tokio crate C-feature-request Category: A feature request. labels May 15, 2024
@mox692 mox692 added the M-task Module: tokio/task label May 16, 2024
@Darksonn
Copy link
Contributor

I would be happy to accept a PR for this.

@Darksonn Darksonn added E-help-wanted Call for participation: Help is requested to fix this issue. E-easy Call for participation: Experience needed to fix: Easy / not much labels May 16, 2024
@hi-rustin
Copy link
Contributor

I am working on it.

@hi-rustin hi-rustin mentioned this issue May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request. E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. M-task Module: tokio/task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add spawn_blocking and spawn_blocking_on to the JoinSet builder hi-rustin/tokio
4 participants
@jbg @Darksonn @hi-rustin @mox692