Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing module interface data when using library functions from dsckeybusinterface.cpp #289

Open
Dilbert66 opened this issue Apr 25, 2022 · 2 comments

Comments

@Dilbert66
Copy link
Contributor

Hi Nikhil, I was updating my library version to your latest develop branch and noticed that it broke a few things with my code. This was related to the splitting off of the module data read functionality out of the dscKeybusInterface.cpp code section to the dscKeybusReader group only. This is a concern since it is very useful to capture external module data such as wireless battery levels. The panel does not send those, but the modules do so it's really handy for that. Could you not instead of just removing the code, just use a define to remove them if not needed but still keep the ability for the dsckeybusinterface to monitor both the panel and module data?

@Dilbert66 Dilbert66 changed the title Missing module interface data when using library dsckeybusinterface Missing module interface data when using library functions from dsckeybusinterface.cpp Apr 25, 2022
@rburkholder
Copy link

rburkholder commented May 3, 2023

Hi @Dilbert66, what are you doing in the meantime? Do you include the dscKeybusReader group code?

edited: I see you have wireless battery capability in your https://github.com/Dilbert66/esphome-dsckeybus/tree/dev dev branch

@Dilbert66
Copy link
Contributor Author

I use my own implentation of this library for my own projects as I had a few specific requirements not supported here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants