-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slow app login #20059
Comments
duplicate of #19992 |
or related to |
thanks @Parveshdhull I have decided to log this issue separately and updated #19992 description. |
Hi @pavloburykh. I could also reproduce this issue on Android, but only once in more than 30 full login/re-login runs. I tried to close the app as well and start from scratch a few times. Given the low frequency of this problem and the fact that the user is still capable of logging in after waiting a few seconds, is this really a high-priority issue? cc @cammellos |
Hey @ilmotta! Thank you for testing the issue. Regarding frequency - we are actually facing it quite often. Maybe it depends on specific data of the account. I assume it might be related to communities/wallet accounts. On the video below you can see me logging the user who is a member of Status community. 2 of 2 logins are very slow. Status-debug-logs - 2024-05-16T150722.520.zip telegram-cloud-document-2-5345893055427789349.mp4 |
Great then @pavloburykh, if we can reproduce this often I think I'll try to reach the same state in the app as you in hopes of increasing the frequency and then I can try to fix. |
@pavloburykh, @churik, could you share with me more details about the account you're using to reproduce this issue? I'm trying to force-logout as suggested by @churik, but even that is not causing abnormalities. Just to confirm our suspicions, can you reproduce the issue in a fresh account, i.e. no extra data such as accounts/friends/etc?
|
Hey @ilmotta! Let me share specific user for reproduction the bug (will send you seedphrase in DM). This user has the following data:
The configuration of the account is default, i.e nothing has been changed in advanced settings, no feature flags have been enabled. For reproduction on develop build:
|
@ilmotta just tried this case (reproduced 2/2 times):
Actual result: login time increased So to me, it looks like as soon as at least one transaction appears in the user’s activity history, this affects the login time.
video_2024-05-17_11-04-31.mp4
video_2024-05-17_11-04-56.mp4 |
Thanks a lot 💯 @qoqobolo and @pavloburykh! I'm going to try your reproduction steps today. |
While investigating why login is slow #20059 and when testing with accounts with communities, I noticed we are logging huge payloads because they include data URLs. This makes debugging the app harder. Therefore, we will now log the full event payload only at the trace level, and at the debug level we only log the event type. This problem was first described by ulisesmac.
all my local accounts for development are slow now, so I looked at it, but unfortunately, there is not much info in geth.log, so it seems like the only way is to look into status-go code and analyze what's happening there, or add more debug data, for my accounts I receive login signal in 15sec |
Thanks for investigating @flexsurfer! I'm already working on this issue, and I could pinpoint a few causes, it's all related to status-go as you said and how the backend login code works until the login signal is finally emitted and the user is redirected to the home screen. |
Hey @qoqobolo, @pavloburykh, @cammellos, I have a few updates deserving your attention. I'll try to give all the context that I have, but I reached a point where we will need to make a decision about the next steps. First and foremost, I could reproduce the slow behavior on a real device Galaxy A71 and in the Android emulator. Right after the user presses the "Login" button, status-go takes over and until it emits a signal I focused my investigation in the case that appeared to be the worst. On Galaxy A71, logging in takes 17+ seconds with an account that has joined the Status community and nothing else (see video). Same in the emulator, but in the emulator it's ~5 seconds (still bad and we shouldn't rely anyway on emulators for this analysis). The slowdown is not random and happens 100% of the time because it's caused by the number of chats the user has. 90% of the time to login (14s+) is spent processing chats in the messenger initialization. The reason the emulator is faster is because each chat is processed in ~40ms, but in the emulator it's more like ~120ms. Okay, so we found the problem, or at least for this particular case :) I investigated slowdowns caused by having transactions in wallet accounts, but I couldn't see any major issue. Additionally, reading the login source code doesn't show any part that blocks
Edit: We aligned the following steps in a call:
|
App login has become very slow. Sometimes it is okay, but sometimes can take up to 5 seconds. Both platforms are affected.
Steps:
Actual result:
We are facing login delay both after logout (re-login) and first login (when we open the app and login). Mind that login delay might have different rootcauses in case of login and re-login.
login.mp4
logs (2).zip
Additional Information
The text was updated successfully, but these errors were encountered: