Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of crucial SearchPaths when executing the wiz command #1080

Open
SidiaDevelopment opened this issue Oct 12, 2023 · 0 comments
Open

Comments

@SidiaDevelopment
Copy link

SidiaDevelopment commented Oct 12, 2023

Describe the bug
I am in the process of updating my custom code generators to Entitas 1.14 and encountered the following bug.
When using dotnet Jenny/Jenny.Generator.Cli.dll wiz the Assets\Entitas of SearchPaths line is automatically removed, resulting in errors when generating

To Reproduce
Steps to reproduce the behavior:

  • Add a custom code generator
  • Use dotnet Jenny/Jenny.Generator.Cli.dll wiz to scan for the new generator
  • Add the new generator and finish the dry run
  • The Assets\Entitas line is now missing
  • Generating results in an error stating the Entitas assembly could not be found, as expected by the removal of the SearchPath

Expected behavior
Do not remove valid SearchPaths

When diving through the jenny code I assume this part is responsible for doing this:
https://github.com/sschmid/Jenny/blob/518529e6dd1f33b816cb30ab216b98c44c07f0dc/src/Jenny.Generator.Cli/FixCommand.cs#L85
As this path technically only contains dependencies and no active plugins, it is seen as unused and removed.

I can offer to create a pull request to jenny, but want to clear beforehand if the following method would be a suitable fix:

  • Add a new property to the Jenny.properties file called Jenny.DependencyPaths
  • Do not autoremove lines from that property on calling the fix function
  • Merge DependencyPaths and SearchPaths on execution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

No branches or pull requests

1 participant