Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for creating PodMonitor or ServiceMonitor #383

Closed
sagikazarmark opened this issue Mar 2, 2022 · 10 comments · Fixed by #473 · May be fixed by #624
Closed

Add support for creating PodMonitor or ServiceMonitor #383

sagikazarmark opened this issue Mar 2, 2022 · 10 comments · Fixed by #473 · May be fixed by #624

Comments

@sagikazarmark
Copy link
Contributor

Expected behaviour

Create PodMonitor/ServiceMonitor object for Redis and Sentinel.

Actual behaviour

Prometheus exporters are integrated into the RedisFailover CRD, but they still require PodMonitors or ServiceMonitors.

Proposed solution

Allow creating PodMonitor or ServiceMonitor resources along with exporters. For example:

apiVersion: databases.spotahome.com/v1
kind: RedisFailover
metadata:
  name: redis
spec:
  redis:
    exporter:
      enabled: true
    monitoring:
      podMonitor:
          enabled: true
  sentinel:
    exporter:
      enabled: true
    monitoring:
      podMonitor:
          enabled: true

Additional details

I'd be happy to draft a PR if you like the idea.
@github-actions
Copy link

This issue is stale because it has been open for 45 days with no activity.

@github-actions github-actions bot added the stale label Apr 17, 2022
@sagikazarmark
Copy link
Contributor Author

Not stale

@github-actions github-actions bot removed the stale label Apr 20, 2022
@github-actions
Copy link

github-actions bot commented Jun 5, 2022

This issue is stale because it has been open for 45 days with no activity.

@github-actions github-actions bot added the stale label Jun 5, 2022
@sagikazarmark
Copy link
Contributor Author

Bump

@github-actions github-actions bot removed the stale label Jun 7, 2022
@github-actions
Copy link

This issue is stale because it has been open for 45 days with no activity.

@github-actions github-actions bot added the stale label Jul 22, 2022
@sagikazarmark
Copy link
Contributor Author

bump

@github-actions github-actions bot removed the stale label Jul 25, 2022
@ese
Copy link
Member

ese commented Sep 5, 2022 •
edited

It would be great count with the feature if you want to make a PR :) @sagikazarmark

@sagikazarmark sagikazarmark mentioned this issue Sep 8, 2022
Merged
@ese ese closed this as completed in #473 Sep 8, 2022
@Wouter0100
Copy link
Contributor

This was closed by error, I'd say. @ese this feature request is regarding ServiceMonitors on the pods managed by the operator, not for the operator itself.

@sagikazarmark
Copy link
Contributor Author

Indeed, I added it to the referenced PR by accident.

@sagikazarmark sagikazarmark mentioned this issue Oct 4, 2022
Closed
@sagikazarmark
Copy link
Contributor Author

Resubmitted the issue, since I can't reopen it. I'll send a PR when I get there.

This was referenced Jun 17, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ese @Wouter0100 @sagikazarmark