Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing definitions of errorQuery and totalQuery #523

Open
susenj opened this issue Aug 17, 2023 · 0 comments
Open

Confusing definitions of errorQuery and totalQuery #523

susenj opened this issue Aug 17, 2023 · 0 comments

Comments

@susenj
Copy link

susenj commented Aug 17, 2023

The definitions of errorQuery and totalQuery according to the comments in the code explicitly mention:

// ErrorQuery is a Prometheus query that will get the number/count of events
	// that we consider that are bad for the SLO (e.g "http 5xx", "latency > 250ms"...).

I have a query that gives some timeseries data which I consider are falling in the bad category of events. Since, the definition says it's the count of those events, should I keep errorQuery as errorQuery: count(myQuery) or shall I keep it as errorQuery: myQuery itself? Which format is correct?

The same goes for totalQuery where I am not sure if I need to give an explicit count() or not?
Could someone please clarify?

Some examples in the repo don't use count() and that's where the definition I quote above differs.

@susenj susenj changed the title Confusing definition of errorQuery and totalQuery Confusing definitions of errorQuery and totalQuery Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant