Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad @brief in energy_ratio_by_chunks #106

Open
Nexxel opened this issue Apr 24, 2019 · 4 comments
Open

Bad @brief in energy_ratio_by_chunks #106

Nexxel opened this issue Apr 24, 2019 · 4 comments

Comments

@Nexxel
Copy link

Nexxel commented Apr 24, 2019

Describe the bug
The actual @brief of energy_ratio_by_chunks in khiva_c is
@brief Calculates the sum of squares of chunk i out of N chunks expressed as a ratio.

  • with the sum of squares over the whole series. segmentFocus should be lower
  • than the number of segments

Expected behavior
The @brief should be:
@brief Calculates the sum of squares of chunk i out of N chunks expressed as a ratio

  • with the sum of squares over the whole series. segment_focus should be lower
  • than the number of segments
@BilguunBatsaikhan
Copy link

@Nexxel excuse me, but do you know how is segment_focus used in the calculation?

@avilchess
Copy link
Contributor

Hi @billydentsu,

This operation divides the sum of square elements within a chunk by the sum of square elements of the whole time series. Thus, the segment_focus parameter receives the segment number you want to compute.

Cheers.

@BilguunBatsaikhan
Copy link

Hi @avilchess, I see. Thanks for explaining.
I have a trained a model, and it is most significant feature seems to be energy_ratio_by_chunks where the segment_focus is the last chunk.
If I may, does this mean that the last few series (values of the last chunk) of my time-series are the most predictive?
Does this make sense?

@avilchess
Copy link
Contributor

@billydentsu
I´m not sure what model are you using, so I may need a better description of your scenario (data, purpose, and models) to provide an accurate answer. I would say that the last chunk of your time series is the one with more conserved energy (w.r.t. the whole time series). Having said that, If your model is paying special attention to this parameter, probably It is having an impact in the classification or segmentation of your training dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants