Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AD Cleanup: Cleanup slang-ir-autodiff-unzip.cpp & slang-ir-autodiff-unzip.h #4181

Open
saipraveenb25 opened this issue May 16, 2024 · 0 comments
Assignees
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:cleanup tech debt and rough edges priority:medium nice to have in next milestone

Comments

@saipraveenb25
Copy link
Collaborator

slang-ir-autodiff-unzip.cpp currently contains very little of the actual unzipping logic and instead contains the extraction pass logic.
This is tech-debt from earlier when we decided to restructure the passes so that extraction/scope-legalization occured at the end rather than after unzipping.

We should move passes into appropriately named files and move the implementations from the header to the .cpp module.

@saipraveenb25 saipraveenb25 added kind:cleanup tech debt and rough edges priority:medium nice to have in next milestone goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang labels May 16, 2024
@saipraveenb25 saipraveenb25 self-assigned this May 16, 2024
@saipraveenb25 saipraveenb25 added this to the Q3 2024 (Summer) milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:cleanup tech debt and rough edges priority:medium nice to have in next milestone
Projects
None yet
Development

No branches or pull requests

1 participant