Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AD Cleanup: Unify how the different transcribers work, and cleanup their dispatch logic #4174

Open
saipraveenb25 opened this issue May 15, 2024 · 0 comments
Assignees
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:cleanup tech debt and rough edges priority:medium nice to have in next milestone

Comments

@saipraveenb25
Copy link
Collaborator

At the moment we have 4 different transcribers that are implemented rather weirdly.

IRBackwardDiffTranscriber generates the derivative function in transcribeFuncHeader rather than just generating the header, while the other 3 versions all generate only the header.
Further, calling transcriberObject.transcribe does not actually generate the function, only the header, and follow-up tasks are added to a global context that the caller has to follow-up by calling transcribeFunc explciitly on each function body.

It may be better to unify this logic with a single point of dispatch, with follow-up transcription requests returned as the result of the .transcribe() call.

Additionally, the word 'transcribe' might not be the best description (since it usually means audio-to-text). Calling them 'generators', 'transformers' or 'translators' might be more apt (thought this isn't really a pressing issue)

@saipraveenb25 saipraveenb25 added kind:cleanup tech debt and rough edges priority:medium nice to have in next milestone goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang labels May 15, 2024
@saipraveenb25 saipraveenb25 added this to the Q2 2024 (Spring) milestone May 15, 2024
@saipraveenb25 saipraveenb25 self-assigned this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:cleanup tech debt and rough edges priority:medium nice to have in next milestone
Projects
None yet
Development

No branches or pull requests

2 participants