Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persist_file() can return a Deferred that is never awaited #6369

Open
wRAR opened this issue May 18, 2024 · 0 comments
Open

persist_file() can return a Deferred that is never awaited #6369

wRAR opened this issue May 18, 2024 · 0 comments
Labels

Comments

@wRAR
Copy link
Member

wRAR commented May 18, 2024

All non-local FilesPipeline store classes (S3FilesStore, GCSFilesStore, FTPFilesStore) return a Deferred from the persist_file() method but FilesPipeline.file_downloaded() ignores the result of this method. Looks like it was this way since the beginning.

I don't have suggestion for a fix because file_downloaded is a sync method.

@wRAR wRAR added the bug label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant