Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm finds 119 vulnerabilities on install #351

Open
oatkiller opened this issue Nov 16, 2019 · 5 comments
Open

npm finds 119 vulnerabilities on install #351

oatkiller opened this issue Nov 16, 2019 · 5 comments

Comments

@oatkiller
Copy link

image

I'm going to take a crack at fixing this unless I'm told not to.

P.S.
Thanks for the cool library

@oatkiller
Copy link
Author

@schteppe I can get rid of 10 vulnerabilities by swapping in grunt-jsdoc in place of grunt-contrib-yuidoc. Any objection? The docs look prettier similar:

Before

image

After

image

No doubt there are minor issues with this swap, but I think the vulnerabilities are a bigger deal.

Only 109 now
image

@oatkiller
Copy link
Author

@schteppe The next big issue is nodeunit. I'm going to take a stab at replacing it w/ jest. My reasoning is simple: lots of people use jest and most modern JS testing frameworks are largely the same. Any objections there?

@oatkiller
Copy link
Author

Good job on having so many tests :) I'm making some progress moving things to jest, but it could take a while. I'll follow up when I get those vulnerabilities to 0.

@oatkiller
Copy link
Author

Still working through porting the tests to jest. I'll get there. Please let me know if this work is something you'll be willing to consider merging.

@jtenner
Copy link

jtenner commented Nov 21, 2019

I appreciate this work! I have no idea if @schteppe plans on supporting p2.js any more. It's difficult work and this project has been pretty silent for the path few years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants