Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequel collection support #188

Open
tombruijn opened this issue Nov 5, 2015 · 1 comment · May be fixed by #189
Open

Sequel collection support #188

tombruijn opened this issue Nov 5, 2015 · 1 comment · May be fixed by #189
Labels

Comments

@tombruijn
Copy link

I'm trying to set up an API that uses Sequel. Trying to present a collection throws this error:

NoMethodError: Entities::Event missing attributename' on #Sequel::Postgres::Dataset:0x007fe4861eb078`

This works with ActiveRecord, but not with Sequel. The check for if an object is a collection is done by checking if the .to_ary method exists on an object. This is true for ActiveRecord, but not for Sequel.

I've made a small workaround to make it work for now, but I feel this should be part of Grape Entity and not Sequel.

module Sequel
  class Dataset
    alias_method :to_ary, :to_a
  end
end

Is there a more reliable way to check if an object is a collection? Such as doing a check on .to_a? Or to check if it is somehow Enumerable?


Example setup:

require "rubygems"
require "pg"
require "sequel"
require "grape"
require "grape-entity"

# Sequel.migration do
#   change do
#     create_table :events do
#       Integer :id, primary_key: true
#       String :name, size: 255
#       DateTime :created_at, null: true, index: true
#     end
#   end
# end

DB = Sequel.connect("postgres://user:password@localhost:5432/my_database")

module Sequel
  class Dataset
    # If this is removed the collection present doesn't work.
    alias_method :to_ary, :to_a
  end
end

class Event < Sequel::Model
end

module Entities
  class Event < Grape::Entity
    expose :name
  end
end

class API < Grape::API
  format :json

  resource :events do
    get do
      present :events, Event.all, with: Entities::Event
    end
  end
end
@dblock
Copy link
Member

dblock commented Nov 6, 2015

Reading http://stackoverflow.com/questions/9467395/whats-the-difference-between-to-a-and-to-ary-in-activerecord it seems like we need to support both to_a and to_ary, so I would take a pull request.

@dblock dblock added the feature label Nov 6, 2015
@martijnbleeker martijnbleeker linked a pull request Nov 6, 2015 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants