-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROOT-10909] Add TMVA python dependencies to the requirements.txt #14553
Comments
Our current understanding is that we lack the following Python packages for the optional runtime dependencies of TMVA
|
@lmoneta could you confirm this is the list of dependencies? It's important to have those fixed, also considering containers and setup of CI nodes. |
Yes, this is the list of dependencies, but they are optional, we should not emit an error if the package is not installed |
but what happens if they are not there? |
For TMVA nothing, if they are not there the corresponding tests are not run. Everything is protected. But I think if we add in the requirements.txt and the package is not there an error in the build is emitted. |
@lmoneta I was wondering if this PR could be merged after all |
Giving an update on this comment: our current understanding is that we lack the following Python packages for the optional runtime dependencies of TMVA:
|
What is stopping us from adding them and close this item for good? |
That the CI will probably become red, because it would enable the GNN tests that were never run on the CI before. But we can work around this by also always disabling the tests: Once that PR is merged, we can close this issue, and I'll open a new one to remind the TMVA guys to re-enable the GNN tests. |
Explain what you would like to see improved and how.
From https://its.cern.ch/jira/browse/ROOT-10909
The PR #5408 will add a requirements.txt file to the repo, which should reflect our dependencies to python packages. The current status does not cover TMVA with xgboost, sklearn and keras as runtime dependencies, which should be added.
ROOT version
Any
Installation method
Any
Operating system
Any
Additional context
No response
The text was updated successfully, but these errors were encountered: