quick-review doesn't autofocus the field

[fregante]

Description

This selector doesn't match anything:

refined-github/source/features/quick-review.tsx

Lines 80 to 81 in e0eeb51

	delegate('.js-reviews-container > details', 'toggle', focusReviewTextarea, {capture: true, signal});

First reported in #7256

How to replicate the issue + URL

1. Open https://github.com/refined-github/sandbox/pull/12/files#review-changes-modal
2. See the field not being focused

Extension version

24.2.8

Browser(s) used

Safari

[sgrell]

hi, it sounds like only the css class needs to be fixed? I could prepare a PR to target the comment textarea or is the selector for some parent element?

[fregante]

Yes I think only the selector needs to be updated. PR welcome

[sgrell]

I had a look at it, unfortunately I couldn't find an element to make the delegate call with toggle work, so that the check for open works. If I disable the if in focusReviewTextarea and only use .js-reviews-container as a selector, the textarea is highlighted but of course now we try to focus the textarea too often.

So I think, I won't be able to help here.

[huehnerlady]

@fregante any idea when you could have a look at this?

[fregante]

PR welcome

[huehnerlady]

@fregante we did have a look at it and unfortunately it did not work out, so there seems to be a different problem there we cannot grasp as we have only very limited knowledge of Typescript