Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup TypedTextGenerator by doing more operations on SymbolLists #8

Open
edwardrowe opened this issue Mar 16, 2017 · 0 comments
Open
Labels

Comments

@edwardrowe
Copy link

edwardrowe commented Mar 16, 2017

We could break the symbol list into two lists - one for visible and one for hidden text. Instead of doing operations on text, we should do operations on the symbol lists.

For example: RemoveFirstOccurance(string, text) uses a string operation to take out tags. We could instead just remove it from the symbol list.

So we build the two strings entirely from symbol lists, then just do a ToString() on each SymbolList.

SymbolList should probably be made into a class.

This is all just to make the code a bit cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant