Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue: #536] - Added annotation @Path("/") when operation is empty #585

Closed

Conversation

jeffersoncleyson
Copy link

@jeffersoncleyson jeffersoncleyson commented Dec 11, 2023

Many thanks for submitting your Pull Request ❤️!

Include @path("/") when the operation is empty

  • According to the issue in some applications the client method without annotation @path("/") causes 404 NOT_FOUND.

Fixes: #536

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this PR!

Can you please add a test case to verify the reported openAPI? #536

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @jeffersoncleyson.
Besides @ricardozanini's comment above, can you please check the failing tests?

@mcruzdev
Copy link
Collaborator

mcruzdev commented Jan 19, 2024

Hi @ricardozanini and @hbelmiro, I believe that this change could potentially cause breaking changes. Would making the default "/" at end optional be a viable solution? Alternatively, if we prefer not to introduce another configuration, we could consider accepting this approach.

It will be the new behavior?

Copy link
Contributor

@ricardozanini @hbelmiro This is being labeled as Stale.

@github-actions github-actions bot added the Stale label Mar 20, 2024
Copy link
Contributor

@ricardozanini @hbelmiro This is being closed due to inactivity.

@github-actions github-actions bot closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate default @Path("/") annotation for client methods
4 participants