Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS in CI - macos-latest is now ARM #801

Open
woodsp-ibm opened this issue May 10, 2024 · 2 comments
Open

MacOS in CI - macos-latest is now ARM #801

woodsp-ibm opened this issue May 10, 2024 · 2 comments
Labels
type: ci 🔧 Related to Continuous Integration workflows

Comments

@woodsp-ibm
Copy link
Member

In #779 I added M1 images so we could test with ARM. Since then macos-latest, and its synonym macos-14 is now an ARM image, see https://github.com/actions/runner-images for image info. So here tests are being run twice on the same image now.

Do we want to run Mac on X86 in which case we would need to update the images being used so one pair in this set of 4 being run is X86 and not ARM as they all are at present. If we do not want to run/test with X86 on Mac then we can simply delete the extra CI I added in #779 rather than say switching them to do X86 (I would keep the ones with "latest" as this is what we do elsewhere).

@edoaltamura edoaltamura added the type: ci 🔧 Related to Continuous Integration workflows label May 16, 2024
@edoaltamura
Copy link
Collaborator

Thanks for logging this matter. We could keep both CI jobs and support both versions for one more 0.x (mid) release and only keep the latest thereafter.

@woodsp-ibm
Copy link
Member Author

woodsp-ibm commented May 16, 2024

We could keep both CI jobs and support both versions

When I did the change to add ARM images to CI macos_latest was an X86 image and macos_14 was an ARM image. Today they are now the same image, i.e. macos_latest and macos_14 refer to the exact same thing. If you follow the above link to the runner images it has a table where you can see this. So presently in CI its running the exact same stuff - we are doing it twice!, it makes no sense now. So in my mind its a question of deciding what to do about the two jobs I added for ARM, at presently its redundant work, switch them to X86 if we want to run tests on that platform, macos-latest-large seems to do that. Or drop them leaving the tests just on ARM for Mac. We can do testing on both platforms if we want - but as CI stands it needs to change. Its really about do we want to keep testing on both ARM and X86 for Mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: ci 🔧 Related to Continuous Integration workflows
Projects
None yet
Development

No branches or pull requests

2 participants